[mythtv-commits] Ticket #12709: Segmentation fault playing a recording with file missing

[MythTV]

#12709: Segmentation fault playing a recording with file missing
-----------------------------------------+-----------------------------
 Reporter:  Peter Bennett <pgbennett@…>  |          Owner:  jyavenard
     Type:  Bug Report - Crash           |         Status:  new
 Priority:  minor                        |      Milestone:  unknown
Component:  MythTV - Video Playback      |        Version:  Master Head
 Severity:  medium                       |     Resolution:
 Keywords:                               |  Ticket locked:  0
-----------------------------------------+-----------------------------

Comment (by rsiddons):

 Hi Peter,

 Thanks for all your Pi work - I must get one sometime.

 I was really responding to your IRC queries but we rarely seem to be
 around at the same time.

 Now I see that #12693 would have prevented the original crash (but not on
 a Pi). This one looks like it solves it on the Pi too, but isn't
 isOpenMaxRender == true when NOT using openmax ?

 IMO the dynamic cast is convoluted. Why not create your virtual !GetName()
 ? It could default to an empty string and only needs to be overridden by
 videoout_omx. It may become useful for someone else later...

 Then your change becomes a much simpler:

 {{{
 bool isOpenMaxRender = false;
 if (ctx->m_player)
 {
     VideoOutput *vo = ctx->player->GetVideoOutput();
     isOpenMaxRender = vo && vo->GetName() == "openmax";
 }
 if (!isOpenMaxRender && !weDisabledGUI)
     ...
 }}}

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12709#comment:4>
MythTV <http://www.mythtv.org>
MythTV Media Center