[mythtv-commits] Ticket #11739: EIT over the air program guide title description mismatch FIXED/SOLVED
MythTV
noreply at mythtv.org
Fri Sep 11 19:55:24 UTC 2015
#11739: EIT over the air program guide title description mismatch FIXED/SOLVED
-----------------------------------+-----------------------------
Reporter: deadletterfile@… | Owner: dekarl
Type: Bug Report - General | Status: assigned
Priority: minor | Milestone: 0.28
Component: MythTV - ATSC | Version: Master Head
Severity: medium | Resolution:
Keywords: EIT title description | Ticket locked: 0
-----------------------------------+-----------------------------
Comment (by deadletterfile@…):
I apologize for gumming up the works with a poor, overly complex patch. I
have only a "production" machine and WAF is a big concern. I got something
that almost completely solved my problems with EIT and shared it in hope
of having the developers use the patch as a guide to inquiry. Stuartm's
criticism was very helpful.
In the patch, libmythtv/tv_rec.cpp: the addition of "return NULL;" in the
function
MPEGStreamData *TVRec::TuningSignalCheck(void) is a "one-liner" and was
documented in bug #11476 and more properly belongs there. I believe the
absence of this one line may be totally responsible for my EIT scanner
crashing, leading to missing program guide data during times of Mythtv
inactivity.
I renamed variable DESC to DESCR as (I believe) DESC is a reserved mysql
variable. The rename could potentially avoid confusion.
The randomization of channels I did was before I discovered the above
"return NULL" and was my attempt to not lose program data by attempting to
update the oldest channels first. If the "return NULL" fixes the problem
of EIT crashes, then this is unnecessary and should be ignored/removed.
Not doing so was laziness on my part.
The removal of caching of ETT data appears to have solved a big source of
title/description mismatches.
I believe everything else was my attempt, however poorly done, to
completely solve the title/description mismatch. I believe until proven
otherwise, mutex locking is a part of the problem (and has not been
completely solved by the submitted patch). It is more than possible that I
did something unnecessarily or even made things worse. I am not much of a
programmer.
If stuartm indicates progress on EIT would be better served by submitting
smaller patches, I can attempt to do that. Otherwise, I will try and
minimize the damage done and stay out of it.
To my knowledge, no Mythtv developers are paid to work on Mythtv. I
understand there are priorities and what I would like to see fixed is
perhaps low on their list. I hope I have exhibited patience, and apologize
if that had not been the case.
--
Ticket URL: <https://code.mythtv.org/trac/ticket/11739#comment:34>
MythTV <http://www.mythtv.org>
MythTV Media Center
More information about the mythtv-commits
mailing list