[mythtv-commits] Ticket #12355: Qt5 Feature Patch - Various Qt5 deprecated construct patches

[MythTV]

#12355: Qt5 Feature Patch - Various Qt5 deprecated construct patches
-------------------------------------------------+-------------------------
     Reporter:  Gary Buhrmaster                  |      Owner:
  <gary.buhrmaster@…>                            |
         Type:  Patch - Feature                  |     Status:  new
     Priority:  minor                            |  Milestone:  unknown
    Component:  MythTV - General                 |    Version:  Master Head
     Severity:  medium                           |   Keywords:  Qt5 feature
Ticket locked:  0                                |
-------------------------------------------------+-------------------------
 Currently, to support compilation with Qt5, MythTV is using
 QT_DISABLE_DEPRECATED_BEFORE to support legacy Qt4 features.  The
 following patches replace legacy (deprecated) code with current code
 constructs, replacing the deprecated code(s) and where necessary
 surrounded by a version check for Qt5, making it safe for any supported Qt
 version.

 These patches were essentially done by semi-automated identification and
 code copy/paste, but have not been tested in battle.  They passed the
 eyeball test, and compile (on Linux).  Caveat emptor.

 While multiple (small) patches were created in order to allow the devs to
 more easily review them, they are intended to be applied as a set.



 Patch 0: Replace QRect intersect with intersected (renamed in Qt4.2)

 github ref:
 https://github.com/garybuhrmaster/mythtv/commit/99aec945b40d56c04c54f2702c8408c523661c70
 [[BR]]
 github git-am ref:
 https://github.com/garybuhrmaster/mythtv/commit/99aec945b40d56c04c54f2702c8408c523661c70.patch

 Patch 1: Qt4 QUrl addQueryItem to Qt5 QUrlQuery addQueryItem porting for
 libs/libmythfreemheg/Programs.cpp

 github ref:
 https://github.com/garybuhrmaster/mythtv/commit/e883a81b1e03c3ff8ebfc44c0c88cb27ce06e866
 [[BR]]
 git git-am ref:
 https://github.com/garybuhrmaster/mythtv/commit/e883a81b1e03c3ff8ebfc44c0c88cb27ce06e866.patch

 Patch 2: Replace fromAscii to fromLatin1 for libs/libmythtv/cardutil.cpp

 github ref:
 https://github.com/garybuhrmaster/mythtv/commit/e7bd1c2c4f465e6ab6759001b8919b3c54c98ca6
 [[BR]]
 github git-am ref:
 https://github.com/garybuhrmaster/mythtv/commit/e7bd1c2c4f465e6ab6759001b8919b3c54c98ca6.patch

 Patch 3: Replace fromAscii to fromLatin1 for libs/libmythtv/dsmcccache.cpp

 github ref:
 https://github.com/garybuhrmaster/mythtv/commit/e49b1358a2ed52037b896bce2f2fda85f7520c8c
 [[BR]]
 github git-am ref:
 https://github.com/garybuhrmaster/mythtv/commit/e49b1358a2ed52037b896bce2f2fda85f7520c8c.patch

 Patch 4: Replace fromAscii to fromLatin1 for libs/libmythui/cecadapter.cpp

 github ref:
 https://github.com/garybuhrmaster/mythtv/commit/900c47d870797ca25b5fb9bdd2312ec9bbd385a3
 [[BR]]
 github git-am ref:
 https://github.com/garybuhrmaster/mythtv/commit/900c47d870797ca25b5fb9bdd2312ec9bbd385a3.patch

 Patch 5: Qt4 QUrl to Qt5 QUrl/QUrlQuery porting for
 libs/libmythtv/AirPlay/mythairplayserver.cpp

 github ref:
 https://github.com/garybuhrmaster/mythtv/commit/f774cd45b4c9a13a3762598409d4dfb1772f6f7b
 [[BR]]
 github git-am ref:
 https://github.com/garybuhrmaster/mythtv/commit/f774cd45b4c9a13a3762598409d4dfb1772f6f7b.patch

 Patch 6: Add QUrlQuery for Qt5 upnp porting libs/libmythupnp/upnpdevice.h
 (included elsewhere)

 github ref:
 https://github.com/garybuhrmaster/mythtv/commit/af207867def689bd5fbf7dd72496124e25b2ebe7
 [[BR]]
 github git-am ref:
 https://github.com/garybuhrmaster/mythtv/commit/af207867def689bd5fbf7dd72496124e25b2ebe7.patch

 Patch 7: Port Qt4 cert.isValid to Qt5 constructs (date checks and
 blacklist) in libs/libmythupnp/httpserver.cpp

 github ref:
 https://github.com/garybuhrmaster/mythtv/commit/a6041a5b647d458210a7d21c2b9b8ae9630e754d
 [[BR]]
 github git-am ref:
 https://github.com/garybuhrmaster/mythtv/commit/a6041a5b647d458210a7d21c2b9b8ae9630e754d.patch

 Patch 8: Qt4 QUrl to Qt5 QUrl/QUrlQuery porting for upnpcdstv

 github ref:
 https://github.com/garybuhrmaster/mythtv/commit/744568cf69e0594bd3b2ccd030966593efb9c908
 [[BR]]
 github git-am ref:
 https://github.com/garybuhrmaster/mythtv/commit/744568cf69e0594bd3b2ccd030966593efb9c908.patch

 Patch 9: Qt4 QUrl to Qt5 QUrl/QUrlQuery porting for upnpcdsmusic

 github ref:
 https://github.com/garybuhrmaster/mythtv/commit/39f48ff94a585c2376c853ad405f3dcaa774e4ae
 [[BR]]
 github git-am ref:
 https://github.com/garybuhrmaster/mythtv/commit/39f48ff94a585c2376c853ad405f3dcaa774e4ae.patch

 Patch 10: Qt4 QUrl to Qt5 QUrl/QUrlQuery porting for upnpcdsvideo

 github ref:
 https://github.com/garybuhrmaster/mythtv/commit/c9235dc3c450171b08aa7f6fc9c3caa409923d22
 [[BR]]
 github git-am ref:
 https://github.com/garybuhrmaster/mythtv/commit/c9235dc3c450171b08aa7f6fc9c3caa409923d22.patch

 IMPORTANT NOTE:

 This last patch removes the QT_DISABLE_DEPRECATED_BEFORE compatibility
 define.  Do '''NOT''' apply this until (a) patch in ticket #12067 is also
 applied, '''AND''' all devs have agreed to using Qt5 constructs (with
 version checking where needed) for future work.

 Patch 11: Remove QT_DISABLE_DEPRECATED_BEFORE

 github ref:
 https://github.com/garybuhrmaster/mythtv/commit/e8e712e539922e44b5085bd6de0019250b4693de
 [[BR]]
 github git-am ref:
 https://github.com/garybuhrmaster/mythtv/commit/e8e712e539922e44b5085bd6de0019250b4693de.patch

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12355>
MythTV <http://www.mythtv.org>
MythTV Media Center