[mythtv-commits] Ticket #12144: Save volume only on TV Player exit (optimize DB usage)

MythTV noreply at mythtv.org
Sat Dec 12 14:43:55 UTC 2015


#12144: Save volume only on TV Player exit (optimize DB usage)
-----------------------------------+----------------------------
 Reporter:  angela.schmid@…        |          Owner:  jyavenard
     Type:  Patch - Feature        |         Status:  closed
 Priority:  minor                  |      Milestone:  0.28
Component:  MythTV - Audio Output  |        Version:  0.27-fixes
 Severity:  low                    |     Resolution:  fixed
 Keywords:  mysql volume save      |  Ticket locked:  0
-----------------------------------+----------------------------

Comment (by Lawrence Rust <lvr@…>):

 In [changeset:"abaf8ddb8ca4f9cc1196a08ca9593498398f948f/mythtv"]:
 {{{
 #!CommitTicketReference repository="mythtv"
 revision="abaf8ddb8ca4f9cc1196a08ca9593498398f948f"
 Audio: Offload dbase updates when volume is changed

 VolumeBase::SetCurrentVolume writes the new volume immediately to the
 dbase.
 This dbase update occurs on the main UI thread and can take several mS
 on a remote FE.  The delay caused by a series of volume changes (e.g. by
 holding down the volume up/down button) can adversely affect video
 playback,
 causing minor loss of a/v sync which results in the player dropping frames
 which in turn is distracting to the viewer.

 This patch delegates volume dbase updates to a separate thread which
 also adds a holdoff period in order to reduce the number of updates.

 LVR 0.27/0234
 Fixes #12144

 Signed-off-by: Roger Siddons <rsiddons at mythtv.org>
 }}}

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12144#comment:5>
MythTV <http://www.mythtv.org>
MythTV Media Center


More information about the mythtv-commits mailing list