[mythtv-commits] Ticket #12016: Watching in progress recording stutters
MythTV
noreply at mythtv.org
Fri May 16 21:22:22 UTC 2014
#12016: Watching in progress recording stutters
---------------------------------------+----------------------------
Reporter: angela.schmid@… | Owner: jyavenard
Type: Bug Report - General | Status: accepted
Priority: minor | Milestone: unknown
Component: MythTV - Video Playback | Version: 0.27-fixes
Severity: medium | Resolution:
Keywords: WatchingRecording stutter | Ticket locked: 0
---------------------------------------+----------------------------
Comment (by reidjr@…):
having slowly trawled through the code on github;
mythtv/libs/libmythtv/mythplayer.cpp
// Handle automatic commercial skipping
uint64_t jumpto = 0;
if (deleteMap.IsEmpty() && (ffrew_skip == 1) &&
(kCommSkipOff != commBreakMap.GetAutoCommercialSkip()))
{
QString msg;
uint64_t frameCount = GetCurrentFrameCount();
// XXX CommBreakMap should use duration map not video_frame_rate
bool jump = commBreakMap.AutoCommercialSkip(jumpto, framesPlayed,
video_frame_rate,
frameCount, msg)
will continually call GetCurrentFrameCount() which calls
GET_FRAMES_WRITTEN for in progress recordings.
Not sure best approach. As I never commflag before end of recording :
if (deleteMap.IsEmpty() && (ffrew_skip == 1) &&
(commBreakMap.HasMap()) &&
(kCommSkipOff != commBreakMap.GetAutoCommercialSkip()))
might work for me, but would leave the issue for those that do commflag
during recording.
--
Ticket URL: <https://code.mythtv.org/trac/ticket/12016#comment:25>
MythTV <http://www.mythtv.org>
MythTV Media Center
More information about the mythtv-commits
mailing list