[mythtv-commits] Ticket #12165: Max episodes expiration ignores autoexpire = 0

[MythTV]

#12165: Max episodes expiration ignores autoexpire = 0
----------------------------------+---------------------
     Reporter:  wowatheron@…      |      Owner:
         Type:  Patch - Bug Fix   |     Status:  new
     Priority:  minor             |  Milestone:  unknown
    Component:  MythTV - General  |    Version:  0.27.1
     Severity:  medium            |   Keywords:
Ticket locked:  0                 |
----------------------------------+---------------------
 If a recording rule is configured to have a maximum number of episodes,
 and an additional recording is scheduled as an override, the oldest
 episode will be expired even if the recording rule has autoexpire turned
 off.

 Steps to reproduce:
 1. Create a recording rule which will record a lot of things, for example
 a power search with the phrase "program.category_type = 'movie'". Turn off
 auto-expire for the rule, and set max episodes to a reasonable value.

 2. Allow MythTV to record the specified number of episodes, it should not
 record more than the value specified.

 3. From the program guide, select another show which matches the rule.
 Myth will indicate the showing is not going to record because too many
 recordings have already been recorded. Select to record this showing.

 4. The show selected in step 3 above will record, and after it completes
 the next time the expiration runs it will delete the oldest show from the
 rule created in step 1.

 Expected behavior:
 Because autoexpire=0 on the recording rule, I would expect it to always
 honor that setting and not expire any recorded shows from the rule. It
 seems reasonable to allow the user to manually schedule a recording that
 happens to match a rule, without affecting shows scheduled on that rule.

 Actual behavior:
 Recorded shows are deleted

 Justification:
 Consider the example rule above, perhaps a user has collected 5 movies to
 watch later. They notice a particularly good movie coming up in the guide,
 and override the rule to force it to record. With the current behavior,
 one of the 5 previously recorded movies will be deleted. This would not be
 the expected outcome, given the rule has auto-expire disabled and they
 manually scheduled a specific showing.

 Proposed solution:
 In autoexpire.cpp AutoExpire::ExpireEpisodesOverMax, exclude recording
 rules with autoexpire=0. I'll attach a patch.

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12165>
MythTV <http://www.mythtv.org>
MythTV Media Center