[mythtv-commits] Ticket #11739: EIT over the air program guide title description mismatch FIXED/SOLVED

[MythTV]

#11739: EIT over the air program guide title description mismatch FIXED/SOLVED
-----------------------------------+-----------------------------
 Reporter:  deadletterfile@…       |          Owner:  stuarta
     Type:  Bug Report - General   |         Status:  assigned
 Priority:  minor                  |      Milestone:  0.28
Component:  MythTV - General       |        Version:  Master Head
 Severity:  medium                 |     Resolution:
 Keywords:  EIT title description  |  Ticket locked:  0
-----------------------------------+-----------------------------

Comment (by deadletterfile@…):

 mythbackend version: (detached from f19d9f8)
 [v0.28-pre-755-gf19d9f8-dirty]

 Attached is libmyth.140128.patch. It is a unifed patch of my changes which
 have
 stablized the use of over-the-air broadcast information on an atsc
 broadcast
 stream. The patch is against the master branch updated to commit
 f19d9f8062
 (Jan 27,2014). As it includes proposed fixes for submitted bugs 11476 and
 11739
 I will attempt to briefly comment only on changes related to
 title/description
 mismatches here.

 The latest adjustment was the elimination of the ETT cache in
 EITHelper::AddETT

 What I theorize has been happening is EIT/ETT mismatches have occurred at
 times
 when tables were updated in the broadcast stream. I do not think EIT or
 ETT are
 checked against the version_number in the latest MGT, therefore
 potentially an
 old table could be used. This theory matches the observation of others
 that the
 problem gets worse with time (as more stations encounter this problem),
 and
 after reboot, there are initially no new title/description mismatches
 (with
 the UpdateDB function adjusted as below).

 I have run the patch on gf19d9f8-dirty for four days (and for 48 hours on
 my
 prior build) and have seen no degradation in service. At least in my case,
 the
 ETT caching seems unnecessary. Alternately, caching could be checked and
 selectively purged before use, or the Add<ETT EIT> functions could be
 synced
 and process data only after the latest ETTs and EITs are known to exist.

 As earlier reported, I continue to eliminate the overwriting of
 program/event
 descriptions based on length in the 'uint DBEvent::UpdateDB' function,
 although
 I admit the original intent of the code escapes me.

 Other changes to eithelper.<h cpp> eitscanner.cpp and atscstreamdata.cpp
 have
 to do with converting QMutex to QMutexLocker or with bug 11476 and my
 attempts
 to resolve that issue. I admit to being less than a newbie with locking.
 The
 attempt was to clarify code and reduce the risk of thread collisions. I do
 not
 vouch for their integrity, however I am having no issues.

 At this time, with this patch installed, all my broadcast schedule issues
 are
 solved. Scheduling is working optimally for me.

 Thank you for your time. - RoyBoy626

--
Ticket URL: <http://code.mythtv.org/trac/ticket/11739#comment:7>
MythTV <http://www.mythtv.org>
MythTV Media Center