[mythtv-commits] Ticket #12070: Qt5 feature patch to resolve signed vs unsigned comparision warning for KeyboardModifier type change

MythTV noreply at mythtv.org
Thu Feb 20 18:13:09 UTC 2014


#12070: Qt5 feature patch to resolve signed vs unsigned comparision warning for
KeyboardModifier type change
-------------------------------------------------+-------------------------
     Reporter:  Gary Buhrmaster                  |      Owner:
  <gary.buhrmaster@…>                            |     Status:  new
         Type:  Patch - Feature                  |  Milestone:  unknown
     Priority:  minor                            |    Version:  Master Head
    Component:  MythTV - General                 |   Keywords:
     Severity:  medium                           |
Ticket locked:  0                                |
-------------------------------------------------+-------------------------
 Qt5 has been released, and some distros are starting to provide it as an
 alternative to Qt4, although I would not expect Qt5 to be the default for
 quite some time. Regardless, one of the changes in Qt5 is changing the
 type of KeyboardModifier from int to uint. This patch uses the correct
 type for the variable kLIRCInvalidKeyCombo in order to avoid a signed vs
 unsigned comparison warning at compile time, and as it is surrounded by a
 version check should be safe for any supported Qt version, and prepares
 MythTV for the inevitable Qt5 default on some distro at some future date
 (probably a few years from now) with no additional compilation warnings.

 github ref:
 https://github.com/garybuhrmaster/mythtv/commit/6dd27d779ec31f8807c2256de26c06981b8aec4b
 github git-am ref:
 https://github.com/garybuhrmaster/mythtv/commit/6dd27d779ec31f8807c2256de26c06981b8aec4b.patch

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12070>
MythTV <http://www.mythtv.org>
MythTV Media Center


More information about the mythtv-commits mailing list