[mythtv-commits] Ticket #12251: Patch - Add logging when file opens fail in datadirect.cpp

[MythTV]

#12251: Patch - Add logging when file opens fail in datadirect.cpp
-------------------------------------------------+-------------------------
     Reporter:  Gary Buhrmaster                  |      Owner:  stuartm
  <gary.buhrmaster@…>                            |     Status:  new
         Type:  Patch - Bug Fix                  |  Milestone:  unknown
     Priority:  minor                            |    Version:  Master Head
    Component:  MythTV - Mythfilldatabase        |   Keywords:
     Severity:  medium                           |
Ticket locked:  0                                |
-------------------------------------------------+-------------------------
 Discussion on mythtv-users pointed out that there are some code paths that
 can result in unreported errors when downloading data from Schedules
 Direct, often due to permission errors when people incorrectly use mixed
 usernames between mythtv-setup, mythbackend, and mythfilldatabase.

 This patch does not address the core issue (re-use of a fixed file name),
 but provides error reporting so that the logs will identify the error(s)
 if a file open fails.  At least the errors will be now be reported (rather
 than invisible).  Better living through logging.

 A later patch (when more fully tested) will use randomized temporary file
 names where possible, mitigating the most common issues.  But I have not
 yet completed my testing, and better logging is appropriate in any case
 (and the later patch will likely require an ABI bump, so should be
 separate anyway).


 github ref:
 https://github.com/garybuhrmaster/mythtv/commit/b6f41381a9a7017fda4ec7b66cbe006bc282879d
 github git-am ref:
 https://github.com/garybuhrmaster/mythtv/commit/b6f41381a9a7017fda4ec7b66cbe006bc282879d.patch

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12251>
MythTV <http://www.mythtv.org>
MythTV Media Center