[mythtv-commits] Ticket #12046: Fix random SBE PlaybackSock timeout in MBE

[MythTV]

#12046: Fix random SBE PlaybackSock timeout in MBE
-----------------------------------------+----------------------------
 Reporter:  Cédric Schieli <cschieli@…>  |          Owner:  stuartm
     Type:  Patch - Bug Fix              |         Status:  accepted
 Priority:  major                        |      Milestone:  unknown
Component:  MythTV - General             |        Version:  0.27-fixes
 Severity:  medium                       |     Resolution:
 Keywords:  SBE PlaybackSock timeout     |  Ticket locked:  0
-----------------------------------------+----------------------------

Comment (by jyavenard):

 it looks to me that the reference count on sock is increased too many
 times:
 {{{
     sock->IncrRef();
     ReferenceLocker rlocker(sock);
 }}}

 this will cause the sock's reference counter twice, and always by one once
 the function exits.

 ultimately, the socket will never be destroyed and will leak

--
Ticket URL: <https://code.mythtv.org/trac/ticket/12046#comment:4>
MythTV <http://www.mythtv.org>
MythTV Media Center