[mythtv-commits] Ticket #11839: Qt5 feature patch to resolve signed vs unsigned comparision warning for QKeySequence count type change

[MythTV]

#11839: Qt5 feature patch to resolve signed vs unsigned comparision warning for
QKeySequence count type change
-------------------------------------------------+-------------------------
     Reporter:  Gary Buhrmaster                  |      Owner:  stuartm
  <gary.buhrmaster@…>                            |     Status:  new
         Type:  Patch - Feature                  |  Milestone:  unknown
     Priority:  trivial                          |    Version:  Master Head
    Component:  MythTV - User Interface Library  |   Keywords:
     Severity:  low                              |
Ticket locked:  0                                |
-------------------------------------------------+-------------------------
 Qt5 has been released, and some distros are starting to provide it as an
 alternative to Qt4, although I would not expect Qt5 to be the default for
 quite some time.  Regardless, one of the changes in Qt5 is changing the
 type of QKeySequence count() from uint to int.  This patch uses the
 correct type for variable in the for loop in order to avoid a signed vs
 unsigned comparison warning at compile time, and as it is surrounded by a
 version check should be safe for any supported Qt version, and prepares
 MythTV for the inevitable Qt5 default on some distro at some future date
 (probably a few years from now) with no additional compilation warnings.

 github ref:
 https://github.com/garybuhrmaster/mythtv/commit/dcc1fa914cf2614543bb274da6faa8a6db543946

 github git-am ref:
 https://github.com/garybuhrmaster/mythtv/commit/dcc1fa914cf2614543bb274da6faa8a6db543946.patch

--
Ticket URL: <http://code.mythtv.org/trac/ticket/11839>
MythTV <http://www.mythtv.org>
MythTV Media Center