[mythtv-commits] Ticket #11942: Patch: Mythburn doesn't handle themes with no intro properly

[MythTV]

#11942: Patch: Mythburn doesn't handle themes with no intro properly
---------------------------------------+------------------------
     Reporter:  faginbagin <mythtv@…>  |      Owner:
         Type:  Patch - Bug Fix        |     Status:  new
     Priority:  minor                  |  Milestone:  unknown
    Component:  Plugin - MythArchive   |    Version:  0.27-fixes
     Severity:  medium                 |   Keywords:  mythburn
Ticket locked:  0                      |
---------------------------------------+------------------------
 If you try to create a DVD using a theme with no intro, mythburn creates a
 DVD that does nothing in many DVD players. Depending on the player, you
 may not be able to get to a menu or a title. The problem is the first
 <pgc> element, which looks like this:
             <pgc entry="title">
                 </pgc>
 Attached is a patch that adds a <post> element to this <pgc> when the
 theme doesn't have an intro. With the patch, the element looks like:
             <pgc entry="title">


                 <post>{g3=1;g2=1;jump menu 2;}</post>
             </pgc>

 To verify the bug and the patch, take any theme with an intro, copy it to
 a new directory and remove or comment out the <intro> element. For
 example:

 cd /usr/share/mythtv/mytharchive/themes/Black
 cp -a . ../Black-no-intro
 cd ../Black-no-intro
 Use your favorite editor to delete the intro element (should be line 13)
 from theme.xml

 Then create a dvd using the theme Black-no-intro and try it in a DVD
 player. Without the attached patch, you probably won't be able to get to
 the menu or to play any titles using normal navigation with arrows and OK
 button.

 Now apply the attached patch, create the DVD using the same theme and try
 it in the same DVD player. You should now see the menu as soon as the DVD
 is loaded and read by the player and be able to play titles listed in the
 menu using the OK and arrow buttons.

 I have verified the problem and the patch using both VLC and a Panasonic
 DVD player.

 Note: my version of mythburn.py has also been patched as described here:
 http://code.mythtv.org/trac/ticket/11758#comment:5
 Without it, mythtranscode will fail. The attached patch does not include
 that fix.

--
Ticket URL: <http://code.mythtv.org/trac/ticket/11942>
MythTV <http://www.mythtv.org>
MythTV Media Center