[mythtv-commits] Ticket #11531: PULL REQUETS: fix bug in mythtranscodes clean-cutting mechanism

[MythTV]

#11531: PULL REQUETS: fix bug in mythtranscodes clean-cutting mechanism
------------------------------------+-----------------------------
 Reporter:  mythtv@…                |          Owner:
     Type:  Patch - Bug Fix         |         Status:  new
 Priority:  minor                   |      Milestone:  unknown
Component:  MythTV - Mythtranscode  |        Version:  Unspecified
 Severity:  medium                  |     Resolution:
 Keywords:                          |  Ticket locked:  0
------------------------------------+-----------------------------

Comment (by mythtv@…):

 The logic is difficult, but the patch is correct. Mythtranscode is asking
 the cutter whether it can drop a frame for the sake of keeping sync. The
 cutter was in the unpatched version returning true (meaning inhibit) which
 would stop mythtranscode dropping the frame, thus putting sync out, but
 internally the cutter would decrease audioFramesToCut so that it would cut
 less audio to restore sync.

 In the new case. The cutter returns false (meaning don't inhibit). That
 allows mythtranscode to drop the frame so that it keeps sync. The cutter
 now doesn't need to alter its internal state for the sake of keeping sync,
 but it does want to record that there is one less frame to drop. Hence it
 must decrease both audioFramesToCut and videoFramesToCut.

 I have to admit, although I wrote the cutter, I understand it only for
 fleeting moments. :-)

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/11531#comment:2>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center