[mythtv-commits] Ticket #11432: 5cced61dd causes stuttering on UK Channel 4 HD recordings

[MythTV]

#11432: 5cced61dd causes stuttering on UK  Channel 4 HD recordings
----------------------------------+-----------------------------
 Reporter:  mythtv@…              |          Owner:
     Type:  Bug Report - General  |         Status:  new
 Priority:  minor                 |      Milestone:  unknown
Component:  MythTV - General      |        Version:  Master Head
 Severity:  medium                |     Resolution:
 Keywords:                        |  Ticket locked:  0
----------------------------------+-----------------------------

Comment (by mythtv@…):

 I'm not sure if this is relevant, but part of the patch doesn't look
 consistent with itself.

 In dtvrecorder.cpp, there is a frameRateMap array, which is initialized
 using the FrameRate constructor. For fractional values, these are
 initialised as FrameRate(24000, 1001), FrameRate(30000, 1001) and
 FrameRate(60000, 1001). The prototype for this constructor is
 FrameRate(uint n, uint d=1).

 Elsewhere in the code, AVRational is initialised with a similar
 constructor AVRational AVRationalInit(int num, int den = 1), and it is
 called in avformatdecoder.cpp with  pkt_dur = AVRationalInit(1001, 60000);

 I am not entirely sure of the usage of AVRational, but it would seem that
 the arguments are swapped (den = 1001 in the FrameRate constructor, num =
 1001 in the AVRational one). Looking at the code I suspect that the
 FrameRate constructor is being called incorrectly, but I can't be sure.

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/11432#comment:2>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center