[mythtv-commits] Ticket #11613: Patch to initialize (and properly copy) the aes key/iv values in httplivestreambuffer.cpp - fixes coverity 1023902

[MythTV]

#11613: Patch to initialize (and properly copy) the aes key/iv values in
httplivestreambuffer.cpp - fixes coverity 1023902
-------------------------------------+-------------------------------------
 Reporter:  Gary Buhrmaster          |           Type:  Patch - Bug Fix
  <gary.buhrmaster@…>                |       Priority:  minor
   Status:  new                      |      Component:  MythTV - HTTP
Milestone:  unknown                  |  Streaming
  Version:  Master Head              |       Severity:  medium
 Keywords:                           |  Ticket locked:  0
-------------------------------------+-------------------------------------
 Static analysis indicated that the key/iv variables were not initialized.
 Strictly speaking, they do not have to be, since they are protected
 by a boolean flag variable.  But to make coverity happy, initialize them
 (note that the init value of zero is not any more correct or wrong than a
 random uninitialized value for the cryptographic operations).

 In addition, the assignment operator did not copy the iv (even though it
 copied the flag variable).  This looks like a real bug.

 Fixes coverty 1023902

 github ref:
 https://github.com/garybuhrmaster/mythtv/commit/c084f6d6a2e2338744b86baa03bce3816caea9db

 githum git-am ref:
 https://github.com/garybuhrmaster/mythtv/commit/c084f6d6a2e2338744b86baa03bce3816caea9db.patch

--
Ticket URL: <http://code.mythtv.org/trac/ticket/11613>
MythTV <http://www.mythtv.org>
MythTV Media Center