[mythtv-commits] Ticket #11582: Patch for errant parenthesis in mmulticastsocketdevice.cpp - fixes coverity 746821
MythTV
noreply at mythtv.org
Sun Jun 9 19:59:09 UTC 2013
#11582: Patch for errant parenthesis in mmulticastsocketdevice.cpp - fixes coverity
746821
-------------------------------------------------+-------------------------
Reporter: Gary Buhrmaster | Owner: dblain
<gary.buhrmaster@…> | Status: new
Type: Patch - Bug Fix | Milestone: unknown
Priority: minor | Version: Master Head
Component: MythTV - UPnP | Keywords:
Severity: medium |
Ticket locked: 0 |
-------------------------------------------------+-------------------------
Static analysis (coverity) detected a comparison that can never be true in
mmulticastsocketdevice.cpp. In fact, there was a logic error due to an
errant parenthesis (one of the right parens should have been to the left
of the 0 being used to check the return from setsockopt rather than
comparing with the sizeof, which resulted in passing an option length of
zero). This patch moves the right paren to where it should have been
(probable typo in the past).
Fixes coverity 746821
Patch:
https://github.com/garybuhrmaster/mythtv/commit/e7969e3996161ac58ab88efa87806ba9d539c21c
--
Ticket URL: <http://code.mythtv.org/trac/ticket/11582>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
More information about the mythtv-commits
mailing list