[mythtv-commits] Ticket #11612: Patch to check the return value from posix_fadvise in fileringbuffer.cpp - fixes coverity 746748 and 766747

MythTV noreply at mythtv.org
Mon Jul 1 17:53:58 UTC 2013


#11612: Patch to check the return value from posix_fadvise in fileringbuffer.cpp -
fixes coverity 746748 and 766747
-------------------------------------+-------------------------------------
 Reporter:  Gary Buhrmaster          |          Owner:  Gary Buhrmaster
  <gary.buhrmaster@…>                |  <gary.buhrmaster@…>
     Type:  Patch - Bug Fix          |         Status:  closed
 Priority:  minor                    |      Milestone:  unknown
Component:  MythTV - General         |        Version:  Master Head
 Severity:  medium                   |     Resolution:  fixed
 Keywords:                           |  Ticket locked:  0
-------------------------------------+-------------------------------------
Changes (by Gary Buhrmaster <gary.buhrmaster@…>):

 * owner:   => Gary Buhrmaster <gary.buhrmaster@…>
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"351c36ac73d664a370b9b12c655604c03ba71ca1/mythtv"]:
 {{{
 #!CommitTicketReference repository="mythtv"
 revision="351c36ac73d664a370b9b12c655604c03ba71ca1"
 Check the return value from posix_fadvise

 Static analysis determined that the return value
 from posix_fadvise was not checked.  Check the
 return, and log if failed (only debug level
 logging, since fadvise should never fail in the
 first place, and if it does fail it should not
 matter (it is, after all, only a hint) but if
 debugging, the failure might tell one something).

 Fixes coverity 746748 and 746747

 Fixes #11612.

 Signed-off-by: Paul Harrison <pharrison at mythtv.org>
 }}}

--
Ticket URL: <http://code.mythtv.org/trac/ticket/11612#comment:3>
MythTV <http://www.mythtv.org>
MythTV Media Center


More information about the mythtv-commits mailing list