[mythtv-commits] Ticket #11635: (Specultive) patch to initialize m_readbuf in mythsystemwindows.cpp
MythTV
noreply at mythtv.org
Mon Jul 1 00:51:56 UTC 2013
#11635: (Specultive) patch to initialize m_readbuf in mythsystemwindows.cpp
-------------------------------------------------+-------------------------
Reporter: Gary Buhrmaster <gary.buhrmaster@…> | Type: Patch -
Status: new | Bug Fix
Milestone: unknown | Priority: minor
Version: Master Head | Component: MythTV
Keywords: | - MythSystem
| Severity: medium
| Ticket locked: 0
-------------------------------------------------+-------------------------
In commit e2ec92f129f32c42442cf5c46ef92da0e7c90d20 m_readbuf was
initialized in mythsystemunix.cpp based on cppcheck warning. Do the same
in mythsystemwindows.cpp for consistency (and because if static analysis
was run on the windows source, it would likely report the same issue).
This is a speculative patch. My attempts at compiling in Windows have not
been successful. This patch looks correct, and is consistent with its
sibling for mythsystemunix.cpp. Nevertheless, it could be bad. If the
windows buildbot manages to be resurrected, and this patch is applied and
causes difficulties I am willing to assist in resolution.
github ref:
https://github.com/garybuhrmaster/mythtv/commit/5c6be52e39dd853543c6796ef9bf602b68c640cf
github git-am ref:
https://github.com/garybuhrmaster/mythtv/commit/5c6be52e39dd853543c6796ef9bf602b68c640cf.patch
--
Ticket URL: <http://code.mythtv.org/trac/ticket/11635>
MythTV <http://www.mythtv.org>
MythTV Media Center
More information about the mythtv-commits
mailing list