[mythtv-commits] Ticket #11288: Cleanup of DVD startup to improve playback reliability

[MythTV]

#11288: Cleanup of DVD startup to improve playback reliability
-----------------------------------+-------------------------------------
 Reporter:  peper03@…              |          Owner:  Richard <peper03@…>
     Type:  Patch - Bug Fix        |         Status:  closed
 Priority:  minor                  |      Milestone:  0.27
Component:  MythTV - DVD Playback  |        Version:  Unspecified
 Severity:  medium                 |     Resolution:  fixed
 Keywords:                         |  Ticket locked:  0
-----------------------------------+-------------------------------------

Comment (by Richard <peper03@…>):

 In [changeset:c1929686fd424b51c9725100e2e326525c879b0d/mythtv]:
 {{{
 #!CommitTicketReference repository="mythtv"
 revision="c1929686fd424b51c9725100e2e326525c879b0d"
 Simplify DVD startup to improve playback reliability

 The startup code for DVD playback jumps around somewhat trying to find
 a playable title, which is then used to create audio/video decoders
 before playback is restarted at firstplay.

 This doesn't always work as it can leave the DVDs VM in an
 inconsistent state and, depending on the DVD, looks ugly as playback
 starts and then restarts or appears to jump somewhere else after a
 couple of seconds. Because the VM can be left in an inconsistent
 state, menu navigation/selection issues can arise, which can make it
 difficult to start playback.

 The attached patch attempts to clean up the startup code. The
 DVDRingBuffer no longer tries to find a playable title in OpenFile??,
 but rather just lets the VM get on with playback. AVFormatDecoder no
 longer processes the initial frames more than is required to create
 decoders. Once this has been achieved, any cached data is flushed
 before jumping back to 'firstplay' (and cleanly resetting the VM). By
 not displaying the initial frames used to determine the decoders and
 flushing the cached data, the ugly jump at the start of some DVDs is
 no longer visible.

 Fixes #11288

 Backport from master [414de880b]

 Signed-off-by: Stuart Morgan <smorgan at mythtv.org>
 }}}

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/11288#comment:3>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center