[mythtv-commits] Ticket #11525: program category clean up

[MythTV]

#11525: program category clean up
------------------------------+-----------------------------
 Reporter:  rwscott@…         |          Owner:
     Type:  Patch - Feature   |         Status:  closed
 Priority:  minor             |      Milestone:  unknown
Component:  MythTV - General  |        Version:  Master Head
 Severity:  medium            |     Resolution:  Won't Fix
 Keywords:                    |  Ticket locked:  0
------------------------------+-----------------------------
Changes (by stuartm):

 * status:  new => closed
 * resolution:   => Won't Fix


Comment:

 I'm going to quote myself from IRC:

  "stuartm:      I can't really argue with the reasoning for the patch just
 sent to -dev, but I think such macros are as clear as mud :/"

  ...

  "stuartm:      I don't know how big a problem it really is, the category
 types haven't changed in years and no-one is proposing extending them any
 time soon, the aim of my commit was to avoid future bugs through typos or
 invalid assumptions such as the Dish EIT one – basically that you could
 stuff any old value into that field"

 In summary, while I appreciate the patch, I think it hurts code
 readability. The content of that enum is never likely to change. The
 reason for switching to the enum in the first places was because the
 category types are used all over the code creating a substantial risk that
 invalid values might be used. The risk of someone adding to the enum
 without updating the array/int is insignificant by comparison.

--
Ticket URL: <http://code.mythtv.org/trac/ticket/11525#comment:2>
MythTV <http://www.mythtv.org>
MythTV Media Center