[mythtv-commits] Ticket #10892: Myth ripper fails to identify CD's correctly

[MythTV]

#10892: Myth ripper fails to identify CD's correctly
----------------------------------+---------------------------------------
 Reporter:  christian.wittrock@…  |          Owner:  Lawrence Rust <lvr@…>
     Type:  Patch - Bug Fix       |         Status:  closed
 Priority:  major                 |      Milestone:  unknown
Component:  Plugin - MythMusic    |        Version:  0.25-fixes
 Severity:  medium                |     Resolution:  fixed
 Keywords:  rip, detection, CD    |  Ticket locked:  0
----------------------------------+---------------------------------------
Changes (by Lawrence Rust <lvr@…>):

 * owner:   => Lawrence Rust <lvr@…>
 * status:  infoneeded_new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"cba55d74506f98e3da0575312c638562e0509dc0/mythtv"]:
 {{{
 #!CommitTicketReference repository="mythtv"
 revision="cba55d74506f98e3da0575312c638562e0509dc0"
 MythMusic: Filter cached cddb discIDs to prevent incorrect CD
 identification

 In cddb.cpp, Dbase::CacheGet uses the QMap::find function to iterate
 over the cached cddb records that match a given discID.  The Qt docs
 for 4.7 say that incrementing the iterator returns the next QMap value
 with the requested key but in testing values with different keys can be
 returned.

 This patch works around this Qt bug by verifying the key.

 Fixes #10892

 Signed-off-by: Lawrence Rust <lvr at softsystem.co.uk>
 Signed-off-by: Stuart Morgan <smorgan at mythtv.org>
 }}}

--
Ticket URL: <http://code.mythtv.org/trac/ticket/10892#comment:12>
MythTV <http://www.mythtv.org>
MythTV Media Center