[mythtv-commits] Ticket #11053: let EITScanner cache negative lookups

MythTV noreply at mythtv.org
Tue Oct 23 23:27:51 UTC 2012


#11053: let EITScanner cache negative lookups
-----------------------------+-----------------------------
 Reporter:  dekarl@…         |          Owner:  stuarta
     Type:  Patch - Feature  |         Status:  new
 Priority:  minor            |      Milestone:  unknown
Component:  MythTV - EIT     |        Version:  Master Head
 Severity:  medium           |     Resolution:
 Keywords:                   |  Ticket locked:  0
-----------------------------+-----------------------------

Comment (by Rune Petersen <rune@…>):

 Another thing, there is something strange with the EITHelper::GetChanID()
 functions.

 1) The map 'srv_to_chanid' stores channel ID as a signed integer, but
 get_chan_id_from_db() returns channel ID an unsigned integer.
 Should the channel ID be signed or unsigned?

 2) if the channel ID is in cache, the the channel ID is clamped to all
 positive numbers and 0 (return std::max(chanid, 0)), but if it isn't in
 the cache, the channel Id is just returned (return chanid)

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/11053#comment:2>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center


More information about the mythtv-commits mailing list