[mythtv-commits] mythtv branch master updated by mdean. v0.26-pre-286-gabfced8

[Git Repo Owner]

The branch, master has been updated on the
mythtv repository by gitolite user mdean.
       via  abfced82a94d2644d1c4df3e332458e947092329 (commit)
      from  e464d29d35a5116d9f03b071b0175b8d63fd898f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit abfced82a94d2644d1c4df3e332458e947092329
Author:    Michael T. Dean <mdean at mythtv.org> at Tue, 15 May 2012 03:31:51 -0400
Committer: Michael T. Dean <mdean at mythtv.org> at Tue, 15 May 2012 03:31:51 -0400
URL:       http://code.mythtv.org/cgit/mythtv/commit/?id=abfced82a94d2644d1c4df3e332458e947092329

Fix the 1299 DB upgrade (DeletedMaxAge update).
The 1299 upgrade modifies DeletedMaxAge for its new meaning, now that
AutoExpireInsteadOfDelete is always enabled.  Previously, 0 meant
"expire when out of disk space" and was the default value; but after
f78f9992 , 0 means "expire immediately" and -1 means "expire when out of
disk space."  Both before and after f78f9992, any positive value means
to expire recording files that many days after deletion.

However, the setting DeletedMaxAge was only ever written to the database
if the user enabled AutoExpireInsteadOfDelete (triggering the
DeletedExpireOptions TriggeredConfigurationGroup) and modified
DeletedMaxAge to some value other than its default of 0.  Therefore,
most users did not actually have a value for DeletedMaxAge in their
databases--whether they had enabled AutoExpireInsteadOfDelete or not.

The DB upgrade needs to change DeletedMaxAge to -1 if and only if
AutoExpireInsteadOfDelete is enabled and DeletedMaxAge has a value of 0
(or is still using the default).  Because of the condition on the
update, it did nothing for users with AutoExpireInsteadOfDelete enabled
but without a value for DeletedMaxAge in the database.  This resulted in
their systems changing from "expire when out of space" to "expire
immediately".

Thanks to Thomas Boehm and Peter on the mythtv-users mailing list for
noticing that their settings didn't carry over through the update.



-----------------------------------------------------------------------

Summary of changes:
 mythtv/libs/libmythtv/dbcheck.cpp |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

--