[mythtv-commits] Ticket #10522: Correct compiler warning about unsigned comparison

MythTV noreply at mythtv.org
Wed Mar 28 18:01:18 UTC 2012


#10522: Correct compiler warning about unsigned comparison
-------------------------------------------------+-------------------------
     Reporter:  Gary Buhrmaster                  |      Owner:  robertm
  <gary.buhrmaster@…>                            |     Status:  new
         Type:  Patch - Bug Fix                  |  Milestone:  unknown
     Priority:  minor                            |    Version:  Master Head
    Component:  MythTV - Blu-ray Playback        |   Keywords:
     Severity:  low                              |
Ticket locked:  0                                |
-------------------------------------------------+-------------------------
 Remove pendantic compiler warning about comparison of unsigned expression
 in bdringbuffer.cpp


 In bdringbuffer, the chapter variable is declared as a unsigned integer.
 The tests for chapter<0 will always be false (and may be optimized out by
 a good compiler).  The supplied patch removes the code which results in
 the (pendantic) warning message.

   change:  if (chapter < 0 || chapter >= GetNumChapters())
   to:      if (chapter >= GetNumChapters())

 Patch attached.

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/10522>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center


More information about the mythtv-commits mailing list