[mythtv-commits] Ticket #10466: VDA playback makes mythfrontend hang with some videos

[MythTV]

#10466: VDA playback makes mythfrontend hang with some videos
----------------------------------+-----------------------------
 Reporter:  jyavenard             |          Owner:  jyavenard
     Type:  Bug Report - General  |         Status:  closed
 Priority:  minor                 |      Milestone:  0.25
Component:  MythTV - General      |        Version:  Unspecified
 Severity:  medium                |     Resolution:  fixed
 Keywords:                        |  Ticket locked:  0
----------------------------------+-----------------------------
Changes (by Github):

 * status:  assigned => closed
 * resolution:   => fixed
 * milestone:  unknown => 0.25


Comment:

 Fix VDA playback for some videos.

 This fix allows playing BBC videos.
 Apple Video Decode Acceleration framework doesn't handle interlaced h264
 properly. So add a quick test to check if video is interlaced or not.

 While our original VDA code was heavily based on XBMC implementation, it
 introduced some errors ; there were some minor leaks and some necessary
 broken h264 encoding workarounds weren't implemented (AVD just hang on
 those)

 Additionally, XBMC has fixed bugs since and the fixes never made it to
 mythtv.

 Tracking what changed where was too time consuming, so shamelessly remove
 our customisation and re-use XBMC initialisation code as-is.
 Additionally, we were using a non-official ffmpeg call
 (ff_find_start_code) which has been renamed and moved since; so the
 previous code would have been broken during the next ffmpeg resync.

 FFmpeg master now supports VDA decoding, but their code doesn't handle any
 of the borderline scenarios handled here. Making it pretty much useless
 for the time being

 Fixes #10466
  Branch:    master
  Changeset: 2c08a7d1788b4a8183a70c288be0cec46a3f36d0

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/10466#comment:2>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center