[mythtv-commits] Ticket #10825: thread safety in video metadata load

[MythTV]

#10825: thread safety in video metadata load
-------------------------------------+-------------------------------------
 Reporter:  George Nassas            |           Type:  Bug Report -
  <gnassas@…>                        |  General
   Status:  new                      |       Priority:  minor
Milestone:  unknown                  |      Component:  MythTV - Video
  Version:  Unspecified              |  Library
 Keywords:                           |       Severity:  medium
                                     |  Ticket locked:  0
-------------------------------------+-------------------------------------
 This is terribly obscure but I have been bit regularly and the backend
 dies without mentioning why so it's quite annoying.

 The metadata loaders in libs/libmythmetadata/dbaccess.cpp keep static
 copies of their various lists for reuse after the first load but when two
 clients trigger "first" loads at the same time the stl inserts stomp on
 each other and it go boom.

 A suggested patch is attached: I added mutexes to the various load_data
 methods and my BE is happier.

 The patch reviewer can decide if it's worth adding protection to the other
 modifier methods.

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/10825>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center