[mythtv-commits] Ticket #10366: libcec configuration detection code mismatched with source code
MythTV
noreply at mythtv.org
Mon Feb 20 22:08:34 UTC 2012
#10366: libcec configuration detection code mismatched with source code
-------------------------------------------------+-------------------------
Reporter: mythtv@… | Owner: stuartm
Type: Patch - Bug Fix | Status: new
Priority: minor | Milestone: unknown
Component: MythTV - User Interface Library | Version: Unspecified
Severity: medium | Keywords: libcec
Ticket locked: 0 |
-------------------------------------------------+-------------------------
The detection code contained within the `mythtv/configure` script is
mismatched to the implementation code contained within
`mythtv/libs/libmythui/cecadapter.cpp`.
The `mythtv/configure` script checks for header files within a `libcec`
subdirectory:
`#include <libcec/cec.h>`
yet `mythtv/libs/libmythui/cecadapter.cpp` contains:
`#include “cec.h”`
the `mythtv/configure` script also checks for the deprecated
`LoadLibCec()` function, which has been removed from libcec version 1.5
whereas `mythtv/libs/libmythui/cecadapter.cpp` has already been switched
to use the new `LibCecInit()` function.
The attached patch homogenises all of the include paths, settling on the:
`#include <libcec/cec.h>`
format. Whilst I consider this approach to be the best one it is worth
noting that it requires correct `#include` statements within the libcec
headers, which were only introduced in version 1.5, and therefore the
minimum required version has been increased accordingly.
The patch also removes the unnecessary `cecc.h` C API header from
`mythtv/libs/libmythui/cecadapter.cpp` as being a C++ source file the
`cec.h` C++ API is the correct and only required header.
--
Ticket URL: <http://code.mythtv.org/trac/ticket/10366>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
More information about the mythtv-commits
mailing list