[mythtv-commits] Ticket #10194: Add formatting support for SRT subtitles

[MythTV]

#10194: Add formatting support for SRT subtitles
------------------------------------------------+--------------------------
 Reporter:  Jim Stichnoth <stichnot@…>          |          Owner:  danielk
     Type:  Patch - Feature                     |         Status:  assigned
 Priority:  minor                               |      Milestone:  0.26
Component:  MythTV - General                    |        Version:  Master
 Severity:  medium                              |  Head
 Keywords:                                      |     Resolution:
                                                |  Ticket locked:  0
------------------------------------------------+--------------------------
Changes (by danielk):

 * milestone:  0.25 => 0.26


Comment:

 Jim, I think making Get708Font(CC708CharacterAttribute attr) a static and
 making m_708fontSizes static is really a regression. It may work when we
 only have one video playing, but I don't want to tie the subtitle screen
 to presenting captions for just one video at a time. I'm also suspicious
 any time a function returning a pointer or reference is made public; in
 this case it could probably remain private but FormattedTextSubtitle could
 be made a friend of SubtitleScreen.

 PS I realize gCC708Fonts has the same problem, but I'd rather fix that
 than further entrench it. If we need to cache that across runs, there has
 to be a better way..

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/10194#comment:7>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center