[mythtv-commits] Ticket #10659: mfdb put icons from xmltv grabbers into local storage instead of the SG

[MythTV]

#10659: mfdb put icons from xmltv grabbers into local storage instead of the SG
-------------------------------------------+-------------------------
     Reporter:  dekarl@…                   |      Owner:  stuartm
         Type:  Bug Report - General       |     Status:  new
     Priority:  minor                      |  Milestone:  unknown
    Component:  MythTV - Mythfilldatabase  |    Version:  Master Head
     Severity:  medium                     |   Keywords:
Ticket locked:  0                          |
-------------------------------------------+-------------------------
 mythfilldatabase was not converted to store the channel icons in the
 storage group in [cda7871]

 The database update should just store the filename instead of the absolute
 path in IconData::Save in mythtv/programs/mythfilldatabase/icondata.cpp
 https://github.com/MythTV/mythtv/blob/master/mythtv/programs/mythfilldatabase/icondata.cpp#L291

 {{{
 MSqlQuery update(MSqlQuery::InitCon());
 update.prepare(
     "UPDATE channel SET icon = :ICON "
     "WHERE chanid = :CHANID");

 update.bindValue(":ICON", fi.filename);
 update.bindValue(":CHANID", fi.chanid);
 }}}
 fi.filename is the absolute path where the icon gets stored. Its the same
 location where the storage group points to.

 the Qt API suggests that this might strip the directory off the filename
 {{{
 update.bindValue(":ICON", QFileInfo(fi.filename).fileName());
 }}}

 notice the subtle difference between http://qt-
 project.org/doc/qt-4.8/qfile.html#fileName and http://qt-
 project.org/doc/qt-4.8/qfileinfo.html#fileName

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/10659>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center