[mythtv-commits] Ticket #10173: Double framerate deinterlacer incorrectly invalidated

[MythTV]

#10173: Double framerate deinterlacer incorrectly invalidated
-------------------------------------+----------------------------
 Reporter:  krose@…                  |          Owner:  markk
     Type:  Bug Report - General     |         Status:  new
 Priority:  minor                    |      Milestone:
Component:  MythTV - Video Playback  |        Version:  Trunk Head
 Severity:  medium                   |     Resolution:
 Keywords:                           |  Ticket locked:  0
-------------------------------------+----------------------------

Comment (by krose@…):

 More info, as I continue to answer my own questions:
 {{{
 #0  MythPlayer::SetVideoParams (this=0x7fd911069b30, width=720,
 height=576, fps=25, scan=kScan_Ignore) at mythplayer.cpp:819
 #1  0x00007fd9587a22c9 in MythPlayer::OpenDummy (this=0x7fd911069b30) at
 mythplayer.cpp:873
 #2  0x00007fd9587a23c6 in MythPlayer::OpenFile (this=0x7fd911069b30,
 retries=4, allow_libmpeg2=true) at mythplayer.cpp:912
 #3  0x00007fd95879cf3c in MythPlayer::StartPlaying (this=0x7fd911069b30)
 at mythplayer.cpp:2596
 #4  0x00007fd9587c43a4 in PlayerContext::StartPlaying (this=0x25706d0,
 maxWait=-1) at playercontext.cpp:455
 #5  0x00007fd9587c4be6 in PlayerContext::CreatePlayer (this=0x25706d0,
 tv=0xac44, widget=0x22ccd80, desiredState=kState_WatchingLiveTV,
 embed=false,
     embedbounds=..., muted=false) at playercontext.cpp:442
 #6  0x00007fd958733075 in TV::StartPlayer (this=0x256e580, mctx=0x25706d0,
 ctx=0x25706d0, desiredState=kState_WatchingLiveTV) at tv_play.cpp:5001
 #7  0x00007fd95875fec3 in TV::HandleStateChange (this=0x256e580,
 mctx=0x25706d0, ctx=0x25706d0) at tv_play.cpp:2079
 #8  0x00007fd9587624a4 in TV::LiveTV (this=0x256e580, showDialogs=true) at
 tv_play.cpp:1468
 #9  0x00007fd95876b231 in TV::StartTV (tvrec=0x0, flags=<optimized out>)
 at tv_play.cpp:306
 #10 0x000000000043bec5 in startTVNormal () at main.cpp:559
 }}}
 This explains where it's coming up with the wrong frames per second.
 SetVideoParams gets called again with the *correct* video parameters after
 the channel is tuned and data starts coming in, but this is too late for
 the deinterlacer check.

 I'm going to work around this temporarily by hard coding more appropriate
 parameters for my locale into OpenDummy, but really it feels like the
 player really should not be created, or should be left in some limbo
 state, until video data comes in; or, even better, it should reconfigure
 itself and potentially change video modes dynamically as the incoming MPEG
 changes.

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/10173#comment:3>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center