[mythtv-commits] Ticket #10146: Cannot edit recording metadata
MythTV
noreply at mythtv.org
Tue Nov 8 21:04:19 UTC 2011
#10146: Cannot edit recording metadata
---------------------------------------------+-----------------------------
Reporter: amlopezalonso@… | Owner: stuartm
Type: Bug Report - General | Status:
Priority: minor | infoneeded_new
Component: MythTV - User Interface Library | Milestone: unknown
Severity: medium | Version: Trunk Head
Keywords: recording metadata | Resolution:
| Ticket locked: 0
---------------------------------------------+-----------------------------
Comment (by furti@…):
in fact it looks like some themes are broken since
changeset:c704430299e176e3372dfc09dad3b0d0dcc1065d
I tried to fix that in Terra:
{{{
diff --git a/mythtv/themes/Terra/recordings-ui.xml b/mythtv/themes/Terra
/recordings-ui.xml
index e65339a..0ae3834 100644
--- a/mythtv/themes/Terra/recordings-ui.xml
+++ b/mythtv/themes/Terra/recordings-ui.xml
@@ -254,18 +254,6 @@
</state>
</statetype>
-<!--
- <textarea name="filesize_str" from="basetextarea">
- <area>360,647,200,30</area>
- <align>right</align>
- </textarea>
-
- <textarea name="freereport" from="basetextarea">
- <area>570,647,300,30</area>
- <align>left</align>
- </textarea>
--->
-
<statetype name="ratingstate" from="baserating">
<position>1193,435</position>
</statetype>
@@ -622,12 +610,12 @@
<shape name="fade" from="basefadebackground" />
<imagetype name="backimg">
- <position>877,78</position>
+ <area>650,78,635,515</area>
<filename>popups/alt_menu_background.png</filename>
</imagetype>
<textarea name="label" from="basetextarea">
- <area>889,93,378,125</area>
+ <area>662,93,615,125</area>
<font>basemedium</font>
<align>allcenter</align>
<value>Edit Recording Metadata</value>
@@ -635,36 +623,67 @@
</textarea>
<textarea name="titlelabel" from="basetextarea">
- <area>889,225,378,30</area>
+ <area>680,230,615,30</area>
<value>Title</value>
- <align>hcenter</align>
+ <align>left</align>
<font>basemedium</font>
</textarea>
- <textedit name="title" from="baseshorttextedit">
- <position>919,250</position>
+ <textedit name="title" from="basetextedit">
+ <position>825,230</position>
</textedit>
- <textarea name="subtitlelabel" from="titlelabel">
- <position>889,305</position>
+ <textarea name="subtitlelabel" from="basetextarea">
+ <area>680,280,565,30</area>
<value>Subtitle</value>
+ <align>left</align>
+ <font>basemedium</font>
</textarea>
- <textedit name="subtitle" from="baseshorttextedit">
- <position>919,330</position>
+ <textedit name="subtitle" from="basetextedit">
+ <position>825,280</position>
</textedit>
- <textarea name="descriptionlabel" from="titlelabel">
- <position>889,385</position>
+ <textarea name="descriptionlabel" from="basetextarea">
+ <area>680,330,565,30</area>
<value>Description</value>
+ <align>left</align>
+ <font>basemedium</font>
</textarea>
- <textedit name="description" from="baseshortmultilinetextedit">
- <position>919,415</position>
+
+ <textedit name="description" from="basetextedit">
+ <area>825,330,437,90</area>
+ </textedit>
+
+ <textarea name="inetreflabel" from="basetextarea">
+ <area>680,425,565,30</area>
+ <align>left</align>
+ <value>Inetref</value>
+ <font>basemedium</font>
+ </textarea>
+
+ <textedit name="inetref" from="basetextedit">
+ <position>825,425</position>
</textedit>
+ <textarea name="seaslabel" from="basetextarea">
+ <area>680,475,565,30</area>
+ <align>left</align>
+ <value>Season/Epsiode</value>
+ <font>basemedium</font>
+ </textarea>
+
+ <spinbox name="season" from="basespinbox">
+ <position>897,475</position>
+ </spinbox>
+
+ <spinbox name="episode" from="basespinbox">
+ <position>1077,475</position>
+ </spinbox>
+
<button name="ok" from="basebutton">
- <position>968,515</position>
+ <position>853,520</position>
<value>OK</value>
</button>
</window>
}}}
But there is still a problem: the text doesn´t wrap properly in multiline,
and also in the title only the end is shown - I think almost everyone
would prefer the beginning.
On the other hand I think it would be useful if we could get more
information what exactly is missing:
{{{
diff --git a/mythtv/programs/mythfrontend/playbackbox.cpp
b/mythtv/programs/mythfrontend/playbackbox.cpp
index dc76ecf..66962e9 100644
--- a/mythtv/programs/mythfrontend/playbackbox.cpp
+++ b/mythtv/programs/mythfrontend/playbackbox.cpp
@@ -5072,6 +5072,8 @@ RecMetadataEdit::RecMetadataEdit(MythScreenStack
*lparent, ProgramInfo *pginfo)
bool RecMetadataEdit::Create()
{
+ int rv=0;
+
if (!LoadWindowFromXML("recordings-ui.xml", "editmetadata", this))
return false;
@@ -5083,13 +5085,45 @@ bool RecMetadataEdit::Create()
m_episodeSpin = dynamic_cast<MythUISpinBox*>(GetChild("episode"));
MythUIButton *okButton = dynamic_cast<MythUIButton*>(GetChild("ok"));
- if (!m_titleEdit || !m_subtitleEdit || !m_inetrefEdit ||
!m_seasonSpin ||
- !m_episodeSpin || !okButton)
+ if (!m_titleEdit)
{
LOG(VB_GENERAL, LOG_ERR, LOC +
- "Window 'editmetadata' is missing required elements.");
- return false;
+ "Window 'editmetadata' is missing 'title' element.");
+ rv=1;
+ }
+ if (!m_subtitleEdit)
+ {
+ LOG(VB_GENERAL, LOG_ERR, LOC +
+ "Window 'editmetadata' is missing 'subtitle' element.");
+ rv=1;
}
+ if (!m_inetrefEdit)
+ {
+ LOG(VB_GENERAL, LOG_ERR, LOC +
+ "Window 'editmetadata' is missing 'inetref' element.");
+ rv=1;
+ }
+ if (!m_seasonSpin)
+ {
+ LOG(VB_GENERAL, LOG_ERR, LOC +
+ "Window 'editmetadata' is missing 'season' element.");
+ rv=1;
+ }
+ if (!m_episodeSpin)
+ {
+ LOG(VB_GENERAL, LOG_ERR, LOC +
+ "Window 'editmetadata' is missing 'epsisode' element.");
+ rv=1;
+ }
+ if (!okButton)
+ {
+ LOG(VB_GENERAL, LOG_ERR, LOC +
+ "Window 'editmetadata' is missing 'ok' element.");
+ rv=1;
+ }
+
+ if (rv == 1 )
+ return false;
m_titleEdit->SetText(m_progInfo->GetTitle());
m_titleEdit->SetMaxLength(128);
}}}
--
Ticket URL: <http://code.mythtv.org/trac/ticket/10146#comment:3>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
More information about the mythtv-commits
mailing list