[mythtv-commits] Ticket #9676: Obtaining program times across daylight savings time change gives inaccurate results

[MythTV]

#9676: Obtaining program times across daylight savings time change gives
inaccurate results
---------------------------------------+----------------------------
 Reporter:  mythtv@…                   |          Owner:  mdean
     Type:  Patch - Bug Fix            |         Status:  assigned
 Priority:  minor                      |      Milestone:  unknown
Component:  MythTV - Mythfilldatabase  |        Version:  0.24-fixes
 Severity:  medium                     |     Resolution:
 Keywords:                             |  Ticket locked:  0
---------------------------------------+----------------------------

Comment (by mythtv@…):

 After looking further, although these changes fix legit bugs, I'm now
 thinking the original problem is because EITHelper calculates a utc offset
 once and uses it after it is no longer valid due to a daylight savings
 time change. This causes the EIT scanner to go around moving show times to
 an hour off.

 I think EITHelper.CompleteEvent should not use utc_offset at all, but
 rather should call startTime.setTimeSpec(Qt::UTC), as in
 {{{
         starttime.setDate(QDate(result.tm_year + 1900,
                                 result.tm_mon + 1,
                                 result.tm_mday));
         starttime.setTime(QTime(result.tm_hour, result.tm_min,
 result.tm_sec));
         starttime.setTimeSpec(Qt::UTC);
 }}}

 However this is deeper in the code than I know how to test properly, and
 I'm also out of time to look at it right now, so I can't swear that I'm
 right on this.

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/9676#comment:4>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center