[mythtv-commits] Ticket #9247: Tuner value not obeyed when using manual IP setting for HDHR

[MythTV]

#9247: Tuner value not obeyed when using manual IP setting for HDHR
--------------------------------+-----------------------------
 Reporter:  wagnerrp            |          Owner:  silicondust
     Type:  Bug Report          |         Status:  infoneeded
 Priority:  minor               |      Milestone:  unknown
Component:  MythTV - HDHomeRun  |        Version:  0.24
 Severity:  medium              |     Resolution:
 Keywords:                      |  Ticket locked:  0
--------------------------------+-----------------------------
Changes (by robertm):

 * status:  assigned => infoneeded


Comment:

 Attaching what I think is the fix here.  I don't own an HDHomeRun so I
 need someone to fix this.

 In the lib resync that broke this, the following code was removed:

 https://github.com/MythTV/mythtv/commit/baf36e4bab565413c8ca3a4738fc7cf51e0e8a4f#L10L159

 if (sscanf(device_str, "%lu.%lu.%lu.%lu", &a[0], &a[1], &a[2], &a[3]) !=
 4) {

 Basically, hdhomerun_device_create_from_str_ip stopped even trying to
 parse the tuner number, and is just hardcoding the tuner number to 0, no
 matter what is passed to it.  Meanwhile, in
 hdhomerun_device_create_from_str_device_id the tuner number is parsed
 properly:

 if (sscanf(device_str, "%lx-%u", &device_id, &tuner) != 2) {

 I have no idea if this was an intentional change, but it is still present
 in the current libhdhomerun code upstream.

 The patch isn't 100% perfect, but I think it should work properly.  I just
 need someone to test it... then we can figure out what patch we can get
 upstream.

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/9247#comment:3>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center