[mythtv-commits] Ticket #9849: [Feature Wish] Watch Recordings with A-Z pre-selector
MythTV
noreply at mythtv.org
Fri Jun 17 15:44:49 UTC 2011
#9849: [Feature Wish] Watch Recordings with A-Z pre-selector
-------------------------------------+-------------------------
Reporter: tobias@… | Owner: janne
Type: Patch - Feature | Status: closed
Priority: minor | Milestone: unknown
Component: MythTV - Video Playback | Version: 0.24
Severity: medium | Resolution: Invalid
Keywords: | Ticket locked: 0
-------------------------------------+-------------------------
Comment (by jpoet):
I just took a quick look at the azselector.patch, and here are some random
thoughts:
It does not look like you are following myth's coding style:
http://www.mythtv.org/wiki/Coding_Standards
Also, please create unified diffs. git will do that by default (e.g. "git
diff > azselector.patch")
It looks like this patch would require all themes to support the new
buttonlist. I can pretty much guaranty that that will not be an
acceptable requirement.
It looks like it populates the new buttonlist with the entire Latin
alphabet, even if there are no show titles that start with a given letter.
If someone was just displaying a "News" recording group, they might only
have a few shows in the list: CBS News, NBC News, etc. To get to NBC
News, would the person have to scroll all the way through
A,B,C,D,E,F,G,H,I,J,K.L.M,N to get there?
Even if the theme does support the new buttonlist, the user might want to
see all the recordings in a single (ALL) list -- does this patch allow for
that?
Is there any need to support diacritic letters, or are those handled under
@ ?
--
Ticket URL: <http://code.mythtv.org/trac/ticket/9849#comment:3>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
More information about the mythtv-commits
mailing list