[mythtv-commits] Ticket #9930: Distorted alsa-output on some soundcards

[MythTV]

#9930: Distorted alsa-output on some soundcards
-----------------------------------+---------------------------
 Reporter:  mac20xx@…              |          Owner:  jyavenard
     Type:  Patch - Bug Fix        |         Status:  new
 Priority:  minor                  |      Milestone:  0.24.1
Component:  MythTV - Audio Output  |        Version:  0.24.1
 Severity:  medium                 |     Resolution:
 Keywords:  distorted alsa output  |  Ticket locked:  0
-----------------------------------+---------------------------

Comment (by jyavenard):

 Your patch makes no sense..
 10      +     if ((size % (output_bytes_per_frame * channels)) != 0) {
 11      +         int size_needed = (size / (output_bytes_per_frame *
 channels)) * channels * output_bytes_per_frame;
 12      +         VBERROR(QString(LOC + "WriteAudio: data not aligned to
 alsa-frame size"));
 13      +         VBERROR(QString(LOC + "            size: %1, size
 needed: %2")
 14      +                         .arg(size).arg(size_needed));
 15      +     }
 16      +

 output_bytes_per_frame is bytes_per_channel * channels ; a frame is made
 of samples for all channels. your testing a modulo of bytes_per_channels *
 channels * channels...

 I think you're are confused between the meaning of a frame, fragment_size
 and period_size... As for a what a "alsa-frame" is, it's the first time
 I've ever heard of such term

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/9930#comment:2>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center