[mythtv-commits] Ticket #9537: MediaMonitor JumpTo plugin broken in commit ed4d961aed836fade236d006b2797f0c044970de

MythTV noreply at mythtv.org
Mon Jan 31 18:55:31 UTC 2011


#9537: MediaMonitor JumpTo plugin broken in commit
ed4d961aed836fade236d006b2797f0c044970de
-------------------------------------------------+-------------------------
 Reporter:  Lawrence Rust <lvr@…>                |          Owner:  stuartm
     Type:  Bug Report                           |         Status:
 Priority:  minor                                |  accepted
Component:  MythTV - General                     |      Milestone:  0.25
 Severity:  medium                               |        Version:  Trunk
 Keywords:                                       |  Head
                                                 |     Resolution:
                                                 |  Ticket locked:  0
-------------------------------------------------+-------------------------

Comment (by stuartm):

 Look at the handlers in the various plugins, there are conditions under
 which they can be called but nothing will happen, so we exit to the main
 menu for no good reason. This is even more important since the global
 setting to 'jump to plugin' was removed leaving just the plugin specific
 settings.

 There are practical reasons for not wanting to jump before we've
 established whether that's the correct action. Let's say that you have CD
 autoplay enabled but you're currently on the CD ripping screen, inserting
 a CD at this point clearly should not exit and start playing instead.

 Under the old arrangement we cannot evaluate whether the plugin is going
 to handle the media without first going to the plugin handler by which
 time we've already exited to the menu. It's clumsy and not especially
 useful if we want to make better use of the media monitor in the longer
 term.

 The media monitor is perhaps one of the most underused features of the
 current code base, it has the potential to be extremely useful but it's
 limited by the callback structure. The changes I'm suggesting are not that
 significant in the overall scheme of things and they open the door to a
 lot of potential benefits. Ultimately it might mean less code than we have
 now, a leaner and more flexible framework. The changes need not take more
 than a few days in total. More importantly they would be moving the code
 in the right direction rather than a hack which only maintains the status
 quo.

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/9537#comment:4>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center


More information about the mythtv-commits mailing list