[mythtv-commits] Ticket #9430: RemoveDirectory name clash

[MythTV]

#9430: RemoveDirectory name clash
-------------------------------------------------+-------------------------
     Reporter:  Lawrence Rust <lvr@…>            |      Owner:  paulh
         Type:  Bug Report                       |     Status:  new
     Priority:  minor                            |  Milestone:  unknown
    Component:  Plugin - MythArchive             |    Version:  Trunk Head
     Severity:  medium                           |   Keywords:
Ticket locked:  0                                |  RemoveDirectory Windows
-------------------------------------------------+-------------------------
 In commit e090e97d2e422e91c289b8728dca674ae4529efb the function
 RemoveDirectory was added.  Unfortunately the same name is #defined in
 <windows.h> to have either a W or A suffix depending on UNICODE.  This
 causes Windows builds of MythArchive to fail with unresolved references to
 RemoveDirectoryW.

 A pragmatic solution is to #undef RemoveDirectory in libs/linmyth/util,cpp
 just before its definition and to do the same just before the inclusion of
 util.h in mythplugins/mytharchive/mytharchivehelper/main.cpp and
 mythplugins/mytharchive/mytharchive/mythburn.cpp.

 A more elegant solution would be to rename it to say MythRemoveDirectory.

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/9430>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center