[mythtv-commits] Ticket #9586: Commit d149a01 (Changed MPUBLIC define) breaks Windows build
MythTV
noreply at mythtv.org
Sat Feb 19 10:54:05 UTC 2011
#9586: Commit d149a01 (Changed MPUBLIC define) breaks Windows build
-------------------------------------------------+-------------------------
Reporter: Lawrence Rust <lvr@…> | Owner: beirdo
Type: Bug Report | Status:
Priority: trivial | assigned
Component: MythTV - General | Milestone: unknown
Severity: medium | Version: Trunk
Keywords: MPUBLIC Windows | Head
| Resolution:
| Ticket locked: 0
-------------------------------------------------+-------------------------
Comment (by Lawrence Rust <lvr@…>):
A bit further. Now it bombs on building mythavtest, the 1st program, New
log attached.
Looks like including version.pro is the problem. With the current
implementation, the apps need to link with libmythbase to access
myth_source_version etc. Not ideal, as each program should have that info
internally.
Don't you get the feeling that this is a fire fighting exercise? In which
case we should look at the implementation. For instance, it is not
necessary, just desirable, for a Windows program to mark an external
function imported from a DLL as dllimport. If it's marked it saves a few
bytes and is slightly faster but can complicate builds. A dll export does
have to be marked though unless every extern function is exported.
--
Ticket URL: <http://code.mythtv.org/trac/ticket/9586#comment:10>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center
More information about the mythtv-commits
mailing list