[mythtv-commits] Ticket #9556: Updated enhanced cutpoint edit functionality patch

[MythTV]

#9556: Updated enhanced cutpoint edit functionality patch
-------------------------------------------------+-------------------------
 Reporter:  Bill Stuff <billstuff2001@…>         |          Owner:
     Type:  Patch - Feature                      |         Status:  new
 Priority:  minor                                |      Milestone:  unknown
Component:  MythTV - General                     |        Version:
 Severity:  medium                               |  Unspecified
 Keywords:                                       |     Resolution:
                                                 |  Ticket locked:  0
-------------------------------------------------+-------------------------

Comment (by markk):

 Bill

 This is a big patch and I haven't had a chance to try and get it working
 with trunk, so please forgive me if I've missed something.

 Can you clarify what additional features this adds? (over and above the
 obvious of providing the extra frames). Implementation details aside, this
 is a lot of code for what appears to be a small amount of fairly niche
 functionality - and something that adds additional overhead for a fully
 completed theme.

 Implementation wise:-

 - I'd personally rather see this displayed and themed as part of the OSD.
 This seems the most logical place to handle it (we already have the
 current frame on screen), avoids the extra main UI integration (and the
 complications involved) and makes it a little more future proof (the
 implementation of guidedrid etc causes many problems and it needs
 changing).

 - I'm not sure I see the utility of displaying a series of frames that
 are, for example, 60seconds apart. frame by frame yes - but otherwise it's
 just confusing.

 - If you stick to the next and previous X frames, you by and large have
 these available already - or at least it would take relatively little work
 to ensure that you have a buffer of 11 frames, and re-position to the
 middle.

 All told, I think I can see a far simpler solution that hence is more
 maintainable and, if done properly, requires minimal theming. Unless I've
 missed the point...

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/9556#comment:2>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center