[mythtv-commits] Ticket #9227: OSD delete dialog contains different text than Watch Recordings delete dialog

[MythTV]

#9227: OSD delete dialog contains different text than Watch Recordings delete
dialog
-------------------------------------------------+-------------------------
 Reporter:  John Veness <John.Veness.mythtv@…>   |          Owner:  mdean
     Type:  Patch - Feature                      |         Status:  closed
 Priority:  trivial                              |      Milestone:  0.25
Component:  MythTV - General                     |        Version:
 Severity:  low                                  |  0.24-fixes
 Keywords:  delete dialog strings                |     Resolution:  Fixed
                                                 |  Ticket locked:  0
-------------------------------------------------+-------------------------
Changes (by mdean):

 * status:  assigned => closed
 * resolution:   => Fixed


Comment:

 John, thanks for the patch.  I pushed the word changes from the patch, but
 I'm going to reject the "add subtitle to the delete dialog" portion of the
 change for now because we need to fix the already-existing non-OSD UI code
 to work properly before adding similar code to the OSD.

 The problem with the existing code in
 PlaybackBox::CreateProgramInfoString() (the code you used as a template
 for the similar code for the OSD) is that it cuts down the subtitle to 16
 characters plus 3 periods (for ellipsis) if the subtitle is longer than
 the title.  This means the cut down functionality is completely
 independent of dialog layout (i.e. other lines in the dialog) and theme
 layout of the dialog itself.  This looks wrong when the first line of text
 in the dialog is 32 characters:
 {{{
 Are you sure you want to delete:
              Fringe
       Night of Desirab...
  Thu Sep 24, 9:00 PM - 10:05 PM
 }}}
 and the full subtitle, "Night of Desirable Objects," is only 26
 characters, which happens to be shorter than both the "question" line
 ("Are you sure you want to delete:") and the line showing times (which is
 30 characters).

 This needs to be fixed to allow mythui to cut down the individual lines
 automatically (and appropriately) for the theme-specified layout rather
 than assuming some fixed max length of a line (meaning the hard-coded
 cutdown in PlaybackBox::CreateProgramInfoString() needs removed).  TTBOMK,
 there is no way existing mythui can cut down individual lines in a
 multiline string that contains line feed characters (\n).  This means we
 either need to fix mythui to look at individual lines when doing cutdown
 on multiline strings or we need to change MythMenu to allow specifying a
 QStringList of lines to add to the message area or ...  Whatever approach
 we takes needs approval from the developers who know theming (such as
 Stuart M, Robert M, or John P).

 I've put this on my TODO list, but if someone were to get to it before me
 (and get approval of the approach from those developers who know theming
 much better than I), please feel free to submit the patch for
 PlaybackBox::CreateProgramInfoString() usage to another ticket, and, if
 desired, include similar code to make the in-OSD delete dialog also
 include the (properly-cut-down) subtitle.

 Again, I like the idea, but we need to fix the existing code, and then we
 can add subtitle to the in-OSD delete dialog.

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/9227#comment:8>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center