[mythtv-commits] mythtv/master commit: 393db20d4 by Michael T. Dean (sphery)

MythTV noreply at mythtv.org
Sun Aug 28 02:14:28 UTC 2011


      Author:  Michael T. Dean <mdean at mythtv.org>
 Change Date:  2011-08-27T19:13:14-07:00
   Push Date:  2011/08/27 19:14:22 -0700
  Repository:  mythtv
      Branch:  master
New Revision:  393db20d4ad06275139fa5ce5b29e7f8b395d475
   Changeset:  https://github.com/MythTV/mythtv/commit/393db20d4

Log:

Use the compile-type for plugins, too.

This change, along with the changes made by Gavin in 21a4198f7 , makes
the plugins install use the --compile-type , as specified by the mythtv
configure arguments.  Since we had set "profile:CONFIG += release", the
plugins were always being stripped by make install, regardless of what
we had specified when configuring the mythtv build.  After the change,
the plugins binaries will be stripped only if mythtv was configured with
--compile-type=release.

Packagers, please note that this means that plugins
($PREFIX/lib/mythtv/plugins/libmyth*.so) will contain debug symbols (for
the first time, ever, TTBOMK) if you compile with --compile-type=debug
or profile, so you may need to extend your "strip debug symbols into
separate debug files" scripts to also handle plugins.

This also means that users can now get useful backtraces for plugins.

(Note, also, that I am by no means a Qt/qmake expert, so if someone sees
a better way of doing this or a reason why it's wrong, please let me
know.  I'm assuming it's right only because it appears to do the right
thing.)

Modified:

   mythplugins/settings.pro



More information about the mythtv-commits mailing list