[mythtv-commits] Ticket #9036: Fix for bug on flowplayer script
MythTV
mythtv at cvs.mythtv.org
Fri Oct 1 03:46:02 UTC 2010
#9036: Fix for bug on flowplayer script
--------------------------------------+-------------------------------------
Reporter: mythtv@… | Owner: kormoc
Type: patch | Status: new
Priority: minor | Milestone: unknown
Component: Plugin - MythWeb | Version: Unspecified
Severity: medium | Keywords: flash flv flowplayer streaming
Ticket locked: 0 |
--------------------------------------+-------------------------------------
The file stream_flv.pl in mythweb/modules/stream is responsible for on the
fly transcoding to flv format, when using the flowplayer in MythWeb
For some reason ffmpeg is only able to transcode to a size with even
height and width.
When calculating the screen size of the file to stream based on the size
of the existing recording, the script attempts to use the function
round_even in Math::Round to round to an even number. Unfortunately this
function only rounds to an even number when rounding a decimal number,
but in some cases, the value passed to round_even is an odd number without
decimals. This causes ffmpeg to be launched with an odd target size, and
ultimately fail.
The 3 calls to round_even in the script need to be replaced with calls to
nearest_floor(2,
Which is part of the same Math::Round package. This will make sure to spit
out only even integers and nothing else.
Attached is the modified script file. Please include this fix into the
source code.
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/9036>
MythTV <http://www.mythtv.org/>
MythTV Media Center
More information about the mythtv-commits
mailing list