[mythtv-commits] mythtv commit: r23711 - in trunk/mythtv by danielk

[mythtv at cvs.mythtv.org]

      Author: danielk
        Date: 2010-03-10 15:37:33 +0000 (Wed, 10 Mar 2010)
New Revision: 23711
   Changeset: http://svn.mythtv.org/trac/changeset/23711

Modified:

   trunk/mythtv/libs/libmythtv/jobqueue.cpp
   trunk/mythtv/libs/libmythtv/playercontext.cpp
   trunk/mythtv/libs/libmythtv/previewgenerator.cpp
   trunk/mythtv/programs/mythbackend/filetransfer.cpp
   trunk/mythtv/programs/mythbackend/mainserver.cpp

Log:

Set the use in MarkAsInUse(false, use) calls. This doesn't change behaviour, but I'll be applying a patch shortly which will print out a useful debugging message if the use has changed since the MarkAsInUse(true, use). The initial use is copied on assignment and not overridden on subsequent MarkAsInUse() calls, so when two different algorithms use the same program and one ends earlier than the other it is possible for the in use mark to be removed prematurely for 15 minutes iff MarkAsInUse was called on the first instance prior to it's being copied to another instance for the subsequent algorithm.  The follow on patch should fix this particular problem, but similar problems are possible depending on ordering.