[mythtv-commits] Ticket #8127: [PATCH] Encode season & episode systematically on 2 char in programid
MythTV
mythtv at cvs.mythtv.org
Mon Mar 8 20:13:23 UTC 2010
#8127: [PATCH] Encode season & episode systematically on 2 char in programid
-----------------------------------------------+----------------------------
Reporter: Chris Browet <cbro@…> | Owner: gigem
Type: enhancement | Status: assigned
Priority: minor | Milestone: unknown
Component: MythTV - Mythfilldatabase | Version: unknown
Severity: medium | Mlocked: 0
-----------------------------------------------+----------------------------
Changes (by mdean):
* owner: stuartm => gigem
* status: new => assigned
Comment:
David, thoughts on this patch/proposal? TTBOMK, it would have the effect
of breaking duplicate matching for all previously-recorded episodes
(except episodes 10-99 in seasons 10-99) for all XMLTV users whose
grabbers report season and episode information. And, I can't think of any
way to retroactively fix programid's for old episodes. So including this
change would likely require deleting the programid from oldrecorded and
hoping that the title/subtitle/description info of future episodes matches
the previously reported info (and we should only clear the programid for
users who will be affected by the change--where identifying who's affected
would be challenging in and of itself).
I'm nearly convinced that this causes more problems than it solves. I
will admit that the current implementation is broken--but I'd guess that
it's a small number of shows (let alone episodes) for which it breaks dup
matching. (There aren't that many shows with more than 9 seasons and
within those shows, it's only certain episodes that are affected.)
For safety and to maintain most functionality, I'd recommend we just
suppress programid creation for an episode when season > 9. That will
allow falling back to title/subtitle/description dup matching for seasons
10+. (BTW, I'm assigning this to you for your input, but I'm happy to
create the patch, myself.)
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8127#comment:2>
MythTV <http://www.mythtv.org/>
MythTV
More information about the mythtv-commits
mailing list