[mythtv-commits] Ticket #8524: Consistency updates/corrections for source translation strings
MythTV
mythtv at cvs.mythtv.org
Wed Jun 2 08:21:43 UTC 2010
#8524: Consistency updates/corrections for source translation strings
-----------------------------------------------------------------+----------
Reporter: Nick Morrott <knowledgejunkie (at) gmail (dot) com> | Owner: reynaldo
Type: patch | Status: new
Priority: minor | Milestone: unknown
Component: Translations | Version: Trunk Head
Severity: medium | Mlocked: 0
-----------------------------------------------------------------+----------
Comment(by Nick Morrott <knowledgejunkie (at) gmail (dot) com>):
Replying to [comment:1 Jonathan Martens <jonathan@…>]:
> Nice work, but after a quick view there are still some inconsistencies.
For some units between brackets you do use 'in' as a prefix where you
removed them for others, e.g.:
>
> {{{
> @@ -80,7 +80,7 @@
> "(" + QObject::tr("default") + ")"),
> PlayGroupDBStorage(this, _parent, "jump")
> {
> - setLabel(QObject::tr("Jump amount (in minutes)"));
> + setLabel(QObject::tr("Jump amount (minutes)"));
> setHelpText(QObject::tr("How many minutes to jump forward or
backward "
> "when the jump keys are pressed."));
> };
> }}}
>
> compared to
>
> {{{
> @@ -303,7 +304,7 @@
> setLabel(QObject::tr("Frequency")+" "+QObject::tr("or")+" "+
> QObject::tr("Channel"));
> setHelpText(QObject::tr(
> - "Specify either the exact frequency in kHz or "
> + "Specify either the exact frequency (in kHz) or
"
> "a valid channel for your 'TV Format'."));
> }
> };
> }}}
Jonathan,
Thanks for the quick feedback. I thought I had caught all of those, the
intention was to remove all (in ...) variants and just have the units in
the parens.
> As well as using abbreviated units:
>
> {{{
> @@ -992,7 +992,7 @@
> SpinBoxSetting(this, min_val, 60000, 250),
> CaptureCardDBStorage(this, parent, "signal_timeout")
> {
> - setLabel(QObject::tr("Signal Timeout (msec)"));
> + setLabel(QObject::tr("Signal Timeout (ms)"));
> setValue(value);
> setHelpText(QObject::tr(
> "Maximum time MythTV waits for any signal when
"
> }}}
>
> or full out written ones:
>
> {{{
> @@ -80,7 +80,7 @@
> "(" + QObject::tr("default") + ")"),
> PlayGroupDBStorage(this, _parent, "jump")
> {
> - setLabel(QObject::tr("Jump amount (in minutes)"));
> + setLabel(QObject::tr("Jump amount (minutes)"));
> setHelpText(QObject::tr("How many minutes to jump forward or
backward "
> "when the jump keys are pressed."));
> };
>
> }}}
The only abbreviated units that I intended to leave in were for
milliseconds and for frequencies. I guess that does make it less
consistent, but this can easily be rectified if required. I think things
are consistent on a per-unit basis.
If a dev could provide their input (such as the preferred style to use in
the label text vs help text), I/we can improve it from here to further
improve consistency.
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/8524#comment:2>
MythTV <http://www.mythtv.org/>
MythTV
More information about the mythtv-commits
mailing list