[mythtv-commits] Ticket #8640: crash locking problems in RingBuffer.cpp and remotefile.cpp

[MythTV]

#8640: crash locking problems in RingBuffer.cpp and remotefile.cpp
------------------------------+---------------------------------------------
 Reporter:  chr               |       Owner:  ijr       
     Type:  defect            |      Status:  new       
 Priority:  minor             |   Milestone:  unknown   
Component:  MythTV - General  |     Version:  0.23-fixes
 Severity:  medium            |     Mlocked:  0         
------------------------------+---------------------------------------------
 Hi!

 Running mythtv0.23-fixes on a ppc-osx box I got this random crash:
 {{{
     Program received signal EXC_BAD_ACCESS, Could not access memory.
     Reason: KERN_PROTECTION_FAILURE at address: 0x00000000
     [Switching to process 16413 thread 0xd0e3]
     0x0054b93c in RemoteFile::Read (this=0x8ee8700, data=0x15f19001,
 size=32768) at remotefile.cpp:528
     528         if (sock->bytesAvailable() > 0)

     (gdb) p sock
     $1 = (class MythSocket *) 0x0

 DOH!
 }}}

 The locking is broken in the whole Class.
 I commented out *getSocket(void) because you are playing with fire and
 that function isn't used.

 While lurking through the code, I found another possible bug in
 Ringbuffer.cpp, see patch

 Also looks like that actual trunk needs these patches, too.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/8640>
MythTV <http://www.mythtv.org/>
MythTV