[mythtv-commits] Ticket #7779: Segfault watching recorded program via vdpau

MythTV mythtv at cvs.mythtv.org
Thu Feb 4 06:34:42 UTC 2010


#7779: Segfault watching recorded program via vdpau
------------------------------------------------+---------------------------
 Reporter:  Kenn Casper <casper0082@…>          |        Owner:  markk     
     Type:  defect                              |       Status:  closed    
 Priority:  minor                               |    Milestone:  0.23      
Component:  MythTV - Video Playback             |      Version:  0.22-fixes
 Severity:  medium                              |   Resolution:  fixed     
  Mlocked:  0                                   |  
------------------------------------------------+---------------------------
Changes (by markk):

  * status:  infoneeded => closed
  * resolution:  => fixed


Comment:

 (In [23467]) Improved VDPAU thread safety.

 Firstly, internalise all access to the display device in MythRenderVDPAU
 to ensure calls are serialised. Secondly, extend and tidy up locking
 within VideoOutputVDPAU to ensure access to the MythRenderVDPAU object
 is always safe when the object is being re-created. Generally this means
 applying the lock in all public methods (hence assuming that private
 methods are safe).

 The only exception to this is VideoOutputVDPAU::DrawSlice. Locking here
 would synchronise the decode and render threads (not a good thing) but
 actually the main issue being addressed here is when the decoder thread
 initiates recreation of the object when the input changes - hence calls
 to InputChanged and DrawSlice should not be concurrent.

 Closes #7779.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/7779#comment:8>
MythTV <http://www.mythtv.org/>
MythTV


More information about the mythtv-commits mailing list