[mythtv-commits] Ticket #9404: DVD: flicker with intermittent black frames when navigating away from a still frame

[MythTV]

#9404: DVD: flicker with intermittent black frames when navigating away from a
still frame
----------------------------------------+------------------------
     Reporter:  linux@…                 |      Owner:  markk
         Type:  Patch - Bug Fix         |     Status:  new
     Priority:  minor                   |  Milestone:  unknown
    Component:  MythTV - DVD Playback   |    Version:  Trunk Head
     Severity:  medium                  |   Keywords:
Ticket locked:  0                       |
----------------------------------------+------------------------
 Hi,

 with release 0.24 I observed sometimes that when navigating away from a
 still frame in the DVD player via the OSD, e.g. to the root menu, the menu
 movie sequence was interrupted by black frames that came and went away
 again.
 When debugging I noticed that there is a race condition in the still frame
 handling: the DVD player first clears all remaining frames in
 mythdvdplayer::!VideoLoop and only then checks whether it was in a still
 frame and needs to reset the videoPaused flag. Since the DVD is read in a
 different thread on a multi-core system it may happen the DVD read thread
 has already moved on to whatever we were navigating to, i.e. the
 !IsInStillThread method returns false and the videoPaused flag does not
 get cleared, resulting in the black frame problem.

 I attached a simple fix for the problem. I have not tested it in trunk,
 but in the 0.24 fixes branch. The fix is against trunk however. The only
 difference is that the method !IsInStillFrame is still called
 !InStillFrame in 0.24.

 Best wishes,

 Martin.

-- 
Ticket URL: <http://code.mythtv.org/trac/ticket/9404>
MythTV <http://code.mythtv.org/trac>
MythTV Media Center