[mythtv-commits] Ticket #6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing
MythTV
mythtv at cvs.mythtv.org
Tue Apr 27 21:10:53 UTC 2010
#6472: Keybinding for NEXTSOURCE and NEXTINPUT do nothing
--------------------------------+-------------------------------------------
Reporter: restorin@… | Owner: ijr
Type: defect | Status: closed
Priority: trivial | Milestone: unknown
Component: MythTV - General | Version: unknown
Severity: low | Resolution: fixed
Mlocked: 0 |
--------------------------------+-------------------------------------------
Comment(by mdean):
(In [24274]) Fix a deadlock in TV::SwitchSource() that occured when using
the NEXTSOURCE/PREVSOURCE key bindings to switch sources.
The code in TV::timerEvent() was holding a lock, causing a deadlock when
TV::SwitchSource() requested the PlayerContext. This changes
TV::SwitchSource() to work like the related TV::SwitchCards() and
TV::ToggleInputs functions by using the PlayerContext that
TV::timerEvent() passes through TV::ProcessKeypress() and, finally, to
TV::ActivePostQHandleAction(), which calls TV::SwitchSource().
This seems to have been broken in the mythtv-vid branch, but the code was
unreachable/untestable due to broken key bindings (which were fixed for
#6472).
Refs #6472. Fixes #8190. Thanks to jafa for finally getting a backtrace.
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/6472#comment:15>
MythTV <http://www.mythtv.org/>
MythTV
More information about the mythtv-commits
mailing list