[mythtv-commits] Ticket #7133: More mythgallery fixes for windows after [21995]

[MythTV]

#7133: More mythgallery fixes for windows after [21995]
----------------------------------------------------+-----------------------
 Reporter:  Jonathan Martens <jonathan at snetram.nl>  |       Owner:  ijr 
     Type:  defect                                  |      Status:  new 
 Priority:  minor                                   |   Milestone:  0.22
Component:  Plugin - MythGallery                    |     Version:  head
 Severity:  medium                                  |     Mlocked:  0   
----------------------------------------------------+-----------------------
 After [21995] I still need a few more interventions to make MythGallery
 compile on windows, one is to fix a linker error as the MSys version of
 libexif is not build:

 {{{
 g++ -enable-stdcall-fixup -Wl,-enable-auto-import -Wl,-enable-runtime-
 pseudo-rel
 oc -Wl,-s -mthreads -Wl -shared -Wl,--out-implib,liblibmythgallery.a -o
 libmythg
 allery.dll object_script.libmythgallery  -L'u:/Qt/4.5.2/lib' -lopengl32
 -lglu32
 -lgdi32 -luser32 -LU:/mythtv/build//lib -LU:/mythtv/build//lib -lfreetype
 -lmp3l
 ame -lmythdb-0.22 -lmythavutil-0.22 -lmythavcodec-0.22 -lmyth-0.22
 -lmythui-0.22
  -lmythupnp-0.22 -LU:/mythtv/build//bin -lexif -lQtSql4 -lQtXml4
 -lQtOpenGL4 -lQ
 tGui4 -lQtNetwork4 -lQtCore4
 u:/mingw-5.1.4/bin/../lib/gcc/mingw32/4.2.4/../../../../mingw32/bin/ld.exe:
 cann
 ot find -lexif
 collect2: ld returned 1 exit status
 make[1]: *** [libmythgallery.dll] Error 1
 make[1]: Leaving directory `/u/mythtv/mythplugins/mythgallery/mythgallery'
 make: *** [sub-mythgallery-make_default] Error 2
 bash.exe"-3.1$
 }}}

 I will attach a patch shortly, but after fixing that there is still an
 error because the
 {{{
 #if NEW_LIB_EXIF
 ...
 #else
 ...
 #endif
 }}}

 clauses seem to make the wrong lines of code active during compilation on
 windows, it uses the lines between

 {{{
 #else
 ...
 #endif
 }}}

 where it should take the instructions between

 {{{
 #if NEW_LIB_EXIF
 ...
 #else
 }}}

 Manually commenting out the offensive lines makes MythGallery compile, but
 I do not know how to properly make the exception in this case, so I am
 unable to create a patch for it, but I guess one of the more experienced
 developers knows how to do it.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/7133>
MythTV <http://www.mythtv.org/>
MythTV